Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TD-1397] ImmutableSignedZoneV2 internal audit fixes #214

Merged
merged 17 commits into from
May 6, 2024
Merged

[TD-1397] ImmutableSignedZoneV2 internal audit fixes #214

merged 17 commits into from
May 6, 2024

Conversation

Sam-Jeston
Copy link
Contributor

@Sam-Jeston Sam-Jeston commented May 1, 2024 •
edited
Loading

This PR addresses the draft findings of the internal audit for ImmutableSignedZoneV2. Noteable changes:

  • Documentation updates
  • Pinned Solidity version 0.8.20
  • Enforce the context contains at least one of our supported substandards
  • Perform logic checks before state change

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 1, 2024 •
edited
Loading

[TD-1397] ImmutableSignedZoneV2 internal audit fixes

Generated at commit: 853143cc43fa0884a9cec42e065069e3272c5318

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
1
0
11
28
42
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@Sam-Jeston Sam-Jeston marked this pull request as ready for review May 1, 2024 23:25
@Sam-Jeston Sam-Jeston requested a review from a team as a code owner May 1, 2024 23:25
@frankisawesome
fix test
7a61f58 
Signed-off-by: Frank Li <[email protected]>
@frankisawesome
fix regression
9f70a7f 
Signed-off-by: Frank Li <[email protected]>
@frankisawesome
update test name
18fe47b 
Signed-off-by: Frank Li <[email protected]>
frankisawesome
frankisawesome previously approved these changes May 1, 2024
View reviewed changes
drinkcoffee
drinkcoffee previously approved these changes May 2, 2024
View reviewed changes
@frankisawesome
add audit file
4b7cdc5 
Signed-off-by: Frank Li <[email protected]>
@frankisawesome frankisawesome dismissed stale reviews from drinkcoffee and themself via 4b7cdc5 May 2, 2024 03:45
frankisawesome
frankisawesome previously approved these changes May 2, 2024
View reviewed changes
@frankisawesome frankisawesome merged commit 15c39af into main May 6, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveen-imtb naveen-imtb naveen-imtb approved these changes

@frankisawesome frankisawesome frankisawesome approved these changes

@drinkcoffee drinkcoffee drinkcoffee left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Sam-Jeston @drinkcoffee @frankisawesome @naveen-imtb